Bug 162944

Summary: Add Megan to contributor's list
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, glenn, megan_gardner, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Megan Gardner 2016-10-04 15:17:22 PDT
Add Megan to committer's list
Comment 1 Megan Gardner 2016-10-04 15:17:41 PDT
Created attachment 290652 [details]
Patch
Comment 2 Beth Dakin 2016-10-04 15:33:49 PDT
Comment on attachment 290652 [details]
Patch

Oh, sorry for not explaining the process better! We will have to nominate you to be a committer, so this patch will come later.
Comment 3 Beth Dakin 2016-10-04 15:37:23 PDT
(In reply to comment #2)
> Comment on attachment 290652 [details]
> Patch
> 
> Oh, sorry for not explaining the process better! We will have to nominate
> you to be a committer, so this patch will come later.

OH! That's the contributors list. I see. Sorry for being thick. Just add a change log, and this will be good.
Comment 4 Tim Horton 2016-10-04 15:39:42 PDT
Comment on attachment 290652 [details]
Patch

If you want, you can add yourself to the "Contributors" section of the file, down near line 3154, so that your name will autocomplete in places.
Comment 5 Megan Gardner 2016-10-04 15:51:59 PDT
Created attachment 290659 [details]
Patch
Comment 6 Tim Horton 2016-10-04 15:53:08 PDT
Comment on attachment 290659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290659&action=review

> Tools/Scripts/webkitpy/common/config/contributors.json:4691
> +      "Megan Gardner" : {

You went too far! This is the reviewers section.
Comment 7 Megan Gardner 2016-10-04 15:58:06 PDT
Created attachment 290660 [details]
Patch
Comment 8 WebKit Commit Bot 2016-10-04 16:23:07 PDT
Comment on attachment 290660 [details]
Patch

Clearing flags on attachment: 290660

Committed r206793: <http://trac.webkit.org/changeset/206793>
Comment 9 WebKit Commit Bot 2016-10-04 16:23:11 PDT
All reviewed patches have been landed.  Closing bug.