Summary: | [GTK] Pasting clipboard in rich text | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luca Bruno <lethalman88> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | alp, lethalman88 | ||||||||
Priority: | P3 | Keywords: | Gtk | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Luca Bruno
2007-12-04 07:28:15 PST
Created attachment 17702 [details]
documentFragment implementation
Created attachment 17712 [details]
complete patch
I written this code according to the Qt implementation, and i think for now it's both complete and enough.
This works well. Can you fix up the patch so: There are no spaces before parentheses: gdk_atom_intern_static_string ("text/html") ChangeLog should use spaces not tabs. Reviewer field should be left empty. + if (fragment) + return fragment.release(); + } + gtk_selection_data_free (data); This looks like a leak. data isn't freed when returning early. Thanks! String text = String::fromUTF8(gtk_clipboard_wait_for_text(clipboard)); This is also a leak. The return value must be freed -- see the code a few lines below for an example. Created attachment 17723 [details]
corrected patch
Thanks for all these hints. Hope this is good this time.
Comment on attachment 17723 [details]
corrected patch
r=me with the changes we discussed.
|