Bug 162897

Summary: Return null when window.open() is popup blocked
Product: WebKit Reporter: Simon Pieters (:zcorpan) <zcorpan>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, ggaren, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Pieters (:zcorpan)
Reported 2016-10-04 03:56:25 PDT
The return value of window.open() when the popup is blocked should be null. WebKit/Chromium return undefined. Gecko/Edge 13 return null. See https://github.com/whatwg/html/pull/1854 https://github.com/whatwg/html/issues/1851 Test http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4541
Attachments
Patch (11.69 KB, patch)
2016-10-04 09:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-04 08:56:35 PDT
Makes sense.
Chris Dumez
Comment 2 2016-10-04 09:51:14 PDT
Created attachment 290608 [details] Patch
Chris Dumez
Comment 3 2016-10-04 09:53:06 PDT
Thanks for the quality bug reports Simon :)
WebKit Commit Bot
Comment 4 2016-10-04 12:02:34 PDT
Comment on attachment 290608 [details] Patch Clearing flags on attachment: 290608 Committed r206777: <http://trac.webkit.org/changeset/206777>
WebKit Commit Bot
Comment 5 2016-10-04 12:02:39 PDT
All reviewed patches have been landed. Closing bug.
Simon Pieters (:zcorpan)
Comment 6 2016-10-06 05:02:36 PDT
\o/
Note You need to log in before you can comment on or make changes to this bug.