Bug 162876

Summary:

Remove Document::elementSheet()

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Antti Koivisto 2016-10-03 12:47:12 PDT

This is a Document owned stylesheet that exists as a context for parsing element inline style. It never contains any rules and is generally confusing.

Comment 1 Antti Koivisto 2016-10-03 13:23:49 PDT

Created attachment 290511 [details]
patch

Comment 2 Andreas Kling 2016-10-03 13:36:12 PDT

Comment on attachment 290511 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290511&action=review

r=me, looks good, very 2011

> Source/WebCore/dom/StyledElement.cpp:201
> +    if (usesStyleBasedEditability(*inlineStyle))
> +        document().setHasElementUsingStyleBasedEditability();

So this is really "has *ever* used style based editability" huh.
I wonder if this optimization is even useful.

Comment 3 WebKit Commit Bot 2016-10-03 14:55:05 PDT

Comment on attachment 290511 [details]
patch

Clearing flags on attachment: 290511

Committed r206753: <http://trac.webkit.org/changeset/206753>

Comment 4 WebKit Commit Bot 2016-10-03 14:55:10 PDT

All reviewed patches have been landed.  Closing bug.