Bug 162876

Summary: Remove Document::elementSheet()
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2016-10-03 12:47:12 PDT
This is a Document owned stylesheet that exists as a context for parsing element inline style. It never contains any rules and is generally confusing.
Attachments
patch (29.41 KB, patch)
2016-10-03 13:23 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-10-03 13:23:49 PDT
Created attachment 290511 [details] patch
Andreas Kling
Comment 2 2016-10-03 13:36:12 PDT
Comment on attachment 290511 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=290511&action=review r=me, looks good, very 2011 > Source/WebCore/dom/StyledElement.cpp:201 > + if (usesStyleBasedEditability(*inlineStyle)) > + document().setHasElementUsingStyleBasedEditability(); So this is really "has *ever* used style based editability" huh. I wonder if this optimization is even useful.
WebKit Commit Bot
Comment 3 2016-10-03 14:55:05 PDT
Comment on attachment 290511 [details] patch Clearing flags on attachment: 290511 Committed r206753: <http://trac.webkit.org/changeset/206753>
WebKit Commit Bot
Comment 4 2016-10-03 14:55:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.