Bug 162844

Summary: Web Inspector: Selection does not show up over execution highlight ranges
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Before
none
[IMAGE] After none

Joseph Pecoraro
Reported 2016-10-01 13:10:45 PDT
Summary: Selection does not show up over execution highlight ranges Steps to Reproduce: 1. Trigger a pause (some expression will be highlighted) 2. Select part of that expression => Selection is not shown, it should be Notes: - CodeMirror selection is behind text markers - CodeMirror has an add-on to help with this: <https://codemirror.net/demo/markselection.html>
Attachments
[PATCH] Proposed Fix (7.75 KB, patch)
2016-10-01 13:14 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Before (666.31 KB, image/png)
2016-10-01 15:49 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (666.31 KB, image/png)
2016-10-01 15:50 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-10-01 13:10:57 PDT
<rdar://problem/28579121>
Joseph Pecoraro
Comment 2 2016-10-01 13:14:06 PDT
Created attachment 290441 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-10-01 15:49:58 PDT
Created attachment 290444 [details] [IMAGE] Before
Joseph Pecoraro
Comment 4 2016-10-01 15:50:17 PDT
Created attachment 290445 [details] [IMAGE] After
Matt Baker
Comment 5 2016-10-01 17:45:05 PDT
Comment on attachment 290441 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=290441&action=review r=me > Source/WebInspectorUI/ChangeLog:21 > + Enable the text selection as text markers addon. Nit: Alternative form "add-on" used above. We should be consistent.
WebKit Commit Bot
Comment 6 2016-10-01 19:49:02 PDT
Comment on attachment 290441 [details] [PATCH] Proposed Fix Clearing flags on attachment: 290441 Committed r206714: <http://trac.webkit.org/changeset/206714>
WebKit Commit Bot
Comment 7 2016-10-01 19:49:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.