Bug 162818

Summary: Turn variation fonts on by default
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jonlee, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162815    
Attachments:
Description Flags
Patch none

Myles C. Maxfield
Reported 2016-09-30 17:50:52 PDT
Turn variation fonts on by default
Attachments
Patch (3.79 KB, patch)
2016-09-30 17:51 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-09-30 17:51:30 PDT
Created attachment 290414 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-09-30 18:04:02 PDT
Comment on attachment 290414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290414&action=review > Source/WebCore/testing/InternalSettings.cpp:656 > - InternalSettingsGuardForSettingsReturn(false); > + InternalSettingsGuardForSettingsReturn(true); Is this necessary? > Source/WebKit2/Shared/WebPreferencesDefinitions.h:294 > - macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, false, "Variation Fonts", "Enable variation fonts") \ > + macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, true, "Variation Fonts", "Enable variation fonts") \ What about WebKit1 defaults?
Myles C. Maxfield
Comment 3 2016-09-30 18:07:19 PDT
Comment on attachment 290414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290414&action=review >> Source/WebCore/testing/InternalSettings.cpp:656 >> + InternalSettingsGuardForSettingsReturn(true); > > Is this necessary? Not really, but consistency is valuable. >> Source/WebKit2/Shared/WebPreferencesDefinitions.h:294 >> + macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, true, "Variation Fonts", "Enable variation fonts") \ > > What about WebKit1 defaults? WebKit1 turns on all experimental defaults regardless of their defaults.
WebKit Commit Bot
Comment 4 2016-09-30 18:28:34 PDT
Comment on attachment 290414 [details] Patch Clearing flags on attachment: 290414 Committed r206701: <http://trac.webkit.org/changeset/206701>
WebKit Commit Bot
Comment 5 2016-09-30 18:28:38 PDT
All reviewed patches have been landed. Closing bug.
Myles C. Maxfield
Comment 6 2016-09-30 19:54:52 PDT
Comment on attachment 290414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290414&action=review >>> Source/WebKit2/Shared/WebPreferencesDefinitions.h:294 >>> + macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, true, "Variation Fonts", "Enable variation fonts") \ >> >> What about WebKit1 defaults? > > WebKit1 turns on all experimental defaults regardless of their defaults. I misspoke - this is only true for testing.
Myles C. Maxfield
Comment 7 2016-09-30 20:51:47 PDT
Committed r206705: <http://trac.webkit.org/changeset/206705>
Myles C. Maxfield
Comment 8 2016-09-30 21:21:22 PDT
Also https://trac.webkit.org/changeset/206705
Note You need to log in before you can comment on or make changes to this bug.