Summary: | Turn variation fonts on by default | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dino, jonlee, simon.fraser, thorton | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 162815 | ||||||
Attachments: |
|
Description
Myles C. Maxfield
2016-09-30 17:50:52 PDT
Created attachment 290414 [details]
Patch
Comment on attachment 290414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290414&action=review > Source/WebCore/testing/InternalSettings.cpp:656 > - InternalSettingsGuardForSettingsReturn(false); > + InternalSettingsGuardForSettingsReturn(true); Is this necessary? > Source/WebKit2/Shared/WebPreferencesDefinitions.h:294 > - macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, false, "Variation Fonts", "Enable variation fonts") \ > + macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, true, "Variation Fonts", "Enable variation fonts") \ What about WebKit1 defaults? Comment on attachment 290414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290414&action=review >> Source/WebCore/testing/InternalSettings.cpp:656 >> + InternalSettingsGuardForSettingsReturn(true); > > Is this necessary? Not really, but consistency is valuable. >> Source/WebKit2/Shared/WebPreferencesDefinitions.h:294 >> + macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, true, "Variation Fonts", "Enable variation fonts") \ > > What about WebKit1 defaults? WebKit1 turns on all experimental defaults regardless of their defaults. Comment on attachment 290414 [details] Patch Clearing flags on attachment: 290414 Committed r206701: <http://trac.webkit.org/changeset/206701> All reviewed patches have been landed. Closing bug. Comment on attachment 290414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290414&action=review >>> Source/WebKit2/Shared/WebPreferencesDefinitions.h:294 >>> + macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, true, "Variation Fonts", "Enable variation fonts") \ >> >> What about WebKit1 defaults? > > WebKit1 turns on all experimental defaults regardless of their defaults. I misspoke - this is only true for testing. Committed r206705: <http://trac.webkit.org/changeset/206705> |