Bug 162805

Summary: Second time going into fullscreen using silverlight, will hide the menu bar and dock for Safari
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2016-09-30 13:52:25 PDT
Second time going into fullscreen using silverlight, will hide the menu bar and dock for Safari
Attachments
Patch (3.85 KB, patch)
2016-09-30 13:57 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-09-30 13:57:05 PDT
Created attachment 290378 [details] Patch
mitz
Comment 2 2016-09-30 14:20:05 PDT
Comment on attachment 290378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290378&action=review > Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:118 > + if (!windowID) Not sure this is needed, because kCGSNullWindowID is not a valid value. > Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:142 > + if (!windowID) Ditto.
Anders Carlsson
Comment 3 2016-09-30 14:22:02 PDT
(In reply to comment #2) > Comment on attachment 290378 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290378&action=review > > > Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:118 > > + if (!windowID) > > Not sure this is needed, because kCGSNullWindowID is not a valid value. > > > Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:142 > > + if (!windowID) > > Ditto. I'm keeping them because -[NSWindow windowNumber] can return 0 according to https://developer.apple.com/reference/appkit/nswindow/1419068-windownumber
Anders Carlsson
Comment 4 2016-09-30 14:35:18 PDT
Committed r206675: <http://trac.webkit.org/changeset/206675>
Note You need to log in before you can comment on or make changes to this bug.