Bug 162781

Summary:

Parse font-variation-settings

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mmaxfield

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Myles C. Maxfield

Reported 2016-09-30 03:18:22 PDT

Created attachment 290317 [details] Patch Parse font-variation-settings

Attachments
Patch (33.17 KB, patch) 2016-09-30 03:18 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (39.10 KB, patch) 2016-09-30 14:25 PDT, Myles C. Maxfield	simon.fraser: review+	Details Formatted Diff Diff
Patch for committing (39.04 KB, patch) 2016-09-30 14:48 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2016-09-30 14:25:04 PDT

Simon Fraser (smfr)

Comment 2 2016-09-30 14:34:59 PDT

Comment on attachment 290383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290383&action=review > Source/WebCore/css/CSSFontVariationValue.h:35 > + static Ref<CSSFontVariationValue> create(FontTag&& tag, float value) Do you really need to use an r-value reference for something that's 4 bytes?

Myles C. Maxfield

Comment 3 2016-09-30 14:48:30 PDT

Created attachment 290389 [details] Patch for committing

Myles C. Maxfield

Comment 4 2016-09-30 15:01:41 PDT

Note You need to log in before you can comment on or make changes to this bug.