Bug 162735

Summary: Allow overriding some NSURLSessionConfiguration properties on a per-NetworkProcess basis
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mitz: review+, buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-yosemite-wk2 none

Description Sam Weinig 2016-09-29 10:45:57 PDT 
Allow overriding some NSURLSessionConfiguration properties on a per-NetworkProcess basis
Comment 1 Sam Weinig 2016-09-29 10:52:03 PDT 
Created attachment 290219 [details]
Patch
Comment 2 mitz 2016-09-29 11:09:46 PDT 
Comment on attachment 290219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290219&action=review

> Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:87
> +    String CTDataConnectionServiceType;

I think this should be capitalized ctDataConnectionServiceType, like httpProxy below.

> Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:51
> +@property (nonatomic, nullable, copy) NSString *sourceApplicationBundleIdentifier WK_API_AVAILABLE(macosx(10.12), ios(10.0));
> +@property (nonatomic, nullable, copy) NSString *sourceApplicationSecondaryIdentifier WK_API_AVAILABLE(macosx(10.12), ios(10.0));
> +#if TARGET_OS_IPHONE
> +@property (nonatomic, nullable, copy) NSString *CTDataConnectionServiceType WK_API_AVAILABLE(ios(10.0));

These new things should have _TBA availability, shouldn’t they?
Comment 3 Build Bot 2016-09-29 12:05:00 PDT 
Comment on attachment 290219 [details]
Patch

Attachment 290219 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2169751

New failing tests:
fast/images/pdf-as-image-with-annotations.html
Comment 4 Build Bot 2016-09-29 12:05:03 PDT 
Created attachment 290228 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5