Bug 162734

Summary: Bindings do not throw a TypeError if a required dictionary member is missing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, cgarcia, commit-queue, darin, ggaren, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://heycam.github.io/webidl/#es-dictionary
Bug Depends on:    
Bug Blocks: 147740    
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews112 for mac-yosemite
none
Patch
none
Patch none

Chris Dumez
Reported 2016-09-29 10:37:25 PDT
Bindings do not throw a TypeError if a required dictionary member is missing. For example, if there is a "required long id" member in a dictionary, and it is missing. Our bindings will currently pass 0 to the implementation instead of throwing a TypeError.
Attachments
Patch (45.54 KB, patch)
2016-10-03 12:04 PDT, Chris Dumez 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-yosemite (759.61 KB, application/zip)
2016-10-03 12:33 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (579.81 KB, application/zip)
2016-10-03 12:49 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews112 for mac-yosemite (484.92 KB, application/zip)
2016-10-03 12:52 PDT, Build Bot 		no flags
Details
Patch (43.21 KB, patch)
2016-10-03 13:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (44.86 KB, patch)
2016-10-03 13:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-03 09:25:05 PDT
Relevant spec: https://heycam.github.io/webidl/#es-dictionary
Chris Dumez
Comment 2 2016-10-03 10:31:17 PDT
I am working on fixing this.
Chris Dumez
Comment 3 2016-10-03 12:04:49 PDT
Created attachment 290501 [details] Patch
Darin Adler
Comment 4 2016-10-03 12:20:18 PDT
Comment on attachment 290501 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290501&action=review > Source/WebCore/ChangeLog:17 > + except for the support for dictionary inheritence that is still missing spelling error: inheritance
Build Bot
Comment 5 2016-10-03 12:33:43 PDT
Comment on attachment 290501 [details] Patch Attachment 290501 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2212487 Number of test failures exceeded the failure limit.
Build Bot
Comment 6 2016-10-03 12:33:47 PDT
Created attachment 290505 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-10-03 12:49:30 PDT
Comment on attachment 290501 [details] Patch Attachment 290501 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2212578 Number of test failures exceeded the failure limit.
Build Bot
Comment 8 2016-10-03 12:49:33 PDT
Created attachment 290507 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 9 2016-10-03 12:52:21 PDT
Comment on attachment 290501 [details] Patch Attachment 290501 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2212576 Number of test failures exceeded the failure limit.
Build Bot
Comment 10 2016-10-03 12:52:25 PDT
Created attachment 290508 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Chris Dumez
Comment 11 2016-10-03 13:38:22 PDT
Created attachment 290512 [details] Patch
Chris Dumez
Comment 12 2016-10-03 13:52:55 PDT
Created attachment 290516 [details] Patch
Geoffrey Garen
Comment 13 2016-10-03 23:09:06 PDT
Comment on attachment 290516 [details] Patch r=me
WebKit Commit Bot
Comment 14 2016-10-03 23:31:23 PDT
Comment on attachment 290516 [details] Patch Clearing flags on attachment: 290516 Committed r206766: <http://trac.webkit.org/changeset/206766>
WebKit Commit Bot
Comment 15 2016-10-03 23:31:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.