Bug 162724

Summary: NetworkSession: HTTP authentication doesn't work if PROTECTION_SPACE_AUTH_CALLBACK is not enabled
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+

Carlos Garcia Campos
Reported 2016-09-29 04:32:03 PDT
NetworkLoad always expects continueCanAuthenticateAgainstProtectionSpace() to be called to complete the authentication challenge, which is only defined when PROTECTION_SPACE_AUTH_CALLBACK is enabled.
Attachments
Patch (21.46 KB, patch)
2016-09-29 04:39 PDT, Carlos Garcia Campos 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-09-29 04:39:37 PDT
Created attachment 290198 [details] Patch
Alex Christensen
Comment 2 2016-09-29 07:55:45 PDT
Comment on attachment 290198 [details] Patch beautiful
Carlos Garcia Campos
Comment 3 2016-09-29 08:33:03 PDT
Committed r206583: <http://trac.webkit.org/changeset/206583>
Note You need to log in before you can comment on or make changes to this bug.