Summary: | [GStreamer] Can't play any video with GSTREAMER_GL enabled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||||
Component: | WebCore Misc. | Assignee: | Mario Sanchez Prada <mario> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jana, magomez, pnormand, yoon | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Mario Sanchez Prada
2016-09-28 04:18:04 PDT
Created attachment 290334 [details] Patch proposal It seems this was my fault after all, since I passed a X11 display type to gst_gl_display_egl_new_with_egl_display() instead of an EGLDisplay[1], because I (naively) took the code from the Wayland codepath without realizing that PlatformDisplayWayland::native() returns a valid EGLDisplay, while PlatformDisplayX11::native() does not. Thus, simply passing the result of PlatformDisplay::eglDisplay() instead of PlatformDisplayX11::native() fixes the issue and I can now play video on my ARM device with GStreamerGL enabled \o/ Please review the attached patch, thanks! [1] https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L265 [2] https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L271 I tried to get GSTREAMER_GL running with the webkitgtk-2.14.0 release last weekend under wayland. Which was pretty successful, except for running into this bug which was resolved by doing the exact same replacement for the wayland case a few lines below. (native display is the wayland display, but it needs the egl display too) Mario, do you plan to update the patch? (In reply to comment #2) > I tried to get GSTREAMER_GL running with the webkitgtk-2.14.0 release last > weekend under wayland. Which was pretty successful, except for running into > this bug which was resolved by doing the exact same replacement for the > wayland case a few lines below. Interesting, I actually asked on IRC about how they wayland patch could actually work but got no answer and the, talking to someone else locally, I was told (and trusted it) that wayland display was actually an EGLDisplay, so I did forgot about that and assumed it would just work.(In reply to comment #3) > Mario, do you plan to update the patch? Yes, I'm doing it now Created attachment 290804 [details]
Patch proposal
Patch updated, please review. Thanks
Committed r206859: <http://trac.webkit.org/changeset/206859> |