Summary: | Adopt #pragma once in JavaScriptCore | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | JavaScriptCore | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bburg, commit-queue, joepeck, keith_miller, mark.lam, msaboff, ossy, pvollan, ryanhaddad, saam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 162682 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-09-28 00:22:01 PDT
Created attachment 290065 [details]
[PATCH] Proposed Fix
Kept my hands busy while I watched the debates
This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`) Comment on attachment 290065 [details] [PATCH] Proposed Fix Clearing flags on attachment: 290065 Committed r206506: <http://trac.webkit.org/changeset/206506> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > Comment on attachment 290065 [details] > [PATCH] Proposed Fix > > Clearing flags on attachment: 290065 > > Committed r206506: <http://trac.webkit.org/changeset/206506> It broke the WinCairo build, see https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/61404 for details. cc-ing port maintainers (In reply to comment #5) > (In reply to comment #3) > > Comment on attachment 290065 [details] > > [PATCH] Proposed Fix > > > > Clearing flags on attachment: 290065 > > > > Committed r206506: <http://trac.webkit.org/changeset/206506> > > It broke the WinCairo build, see > https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/61404 > for details. cc-ing port maintainers clean build is still in progress: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/61407 Let's see if it fixes the build issue or not. I thought we held off on using #pragma once in JavaScriptCore because there's a conflict between the use of regular headers and forwarding headers on Windows. For example: #include <runtime/VM.h> #include <JavaScriptCore/VM.h> .. would result in a redefinition of the VM class because #pragma once treats them as 2 different headers. Was this problem already solved? (In reply to comment #7) > I thought we held off on using #pragma once in JavaScriptCore because > there's a conflict between the use of regular headers and forwarding headers > on Windows. For example: > > #include <runtime/VM.h> > #include <JavaScriptCore/VM.h> > > .. would result in a redefinition of the VM class because #pragma once > treats them as 2 different headers. Was this problem already solved? Oh wow I didn't even know that was an issue. I'm not sure if it was solved. Re-opened since this is blocked by bug 162682 Committed build fix for Windows in <http://trac.webkit.org/changeset/206521> (In reply to comment #10) > Committed build fix for Windows in <http://trac.webkit.org/changeset/206521> I started the rollout process before your build fix was committed. Rolled back in with http://trac.webkit.org/changeset/206525 Sorry for the mayhem this may have caused. =( Thanks for the follow-up windows fix. (In reply to comment #7) > I thought we held off on using #pragma once in JavaScriptCore because > there's a conflict between the use of regular headers and forwarding headers > on Windows. For example: > > #include <runtime/VM.h> > #include <JavaScriptCore/VM.h> > > .. would result in a redefinition of the VM class because #pragma once > treats them as 2 different headers. Was this problem already solved? Interesting. I had not know that when I made the changes. Seems Windows did encounter this issue, but if it was only a handful of instances we should be fine. |