Bug 162613 – [GTK] Improve OS X UA quirk

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Michael Catanzaro]

Add a fake OS X version number to the Macintosh quirk user agent, in order to more convincingly pretend to be OS X.

[Michael Catanzaro]

Created attachment 289956 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 289956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289956&action=review

> Source/WebCore/platform/gtk/UserAgentGtk.cpp:134
> -        uaString.appendLiteral(" Mac OS X");
> +        uaString.appendLiteral(" Mac OS X 10_12");

is there any website broken because of this?

[Michael Catanzaro]

(In reply to comment #2)
> is there any website broken because of this?

Not that I know of. Consider that this is a quirk that was previously only used at yahoo.com; I am just improving the quirk.

[Carlos Garcia Campos]

Comment on attachment 289956 [details]
Patch

Ok, update the unit tests.

[Michael Catanzaro]

(In reply to comment #4)
> Comment on attachment 289956 [details]
> Patch
> 
> Ok, update the unit tests.

I don't want to, because (a) updating the test would not accomplish much, as it would be difficult to unintentionally remove the hardcoded version, and (b) I want to change the version string here without having to modify the test. I will update the unit tests for the other two patches, though.

[WebKit Commit Bot]

Comment on attachment 289956 [details]
Patch

Rejecting attachment 289956 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 289956, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/gtk/UserAgentGtk.cpp
Hunk #1 FAILED at 131.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/gtk/UserAgentGtk.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Garcia Campos']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2218936

[Michael Catanzaro]

Committed r206826: <http://trac.webkit.org/changeset/206826>