Bug 162609

Summary: [cmake] Simplify Clang checks and prepare for compiler ID split
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, gyuyoung.kim, lforschler, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2016-09-27 06:42:13 PDT
CMake 3.x introduces separate compiler id for AppleClang, making condition if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang") inappropriate as a test for any clang version. Introduce COMPILER_IS_CLANG instead, which is also shorter that CMAKE_CXX_COMPILER_ID comparison.
Attachments
Patch (5.26 KB, patch)
2016-09-27 06:45 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-09-27 06:45:38 PDT
Created attachment 289939 [details] Patch
WebKit Commit Bot
Comment 2 2016-09-27 09:04:31 PDT
Comment on attachment 289939 [details] Patch Clearing flags on attachment: 289939 Committed r206437: <http://trac.webkit.org/changeset/206437>
WebKit Commit Bot
Comment 3 2016-09-27 09:04:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.