Bug 162586

Summary: AX: Meter: [Mac] Content in label element should be used as AXTitle or AXDescription
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch none

Nan Wang
Reported 2016-09-26 18:20:24 PDT
When an meter element is associated (id/for) with, or wrapped inside a label element, the AXTitle and AXDescription is unaffected by the content in the label element.
Attachments
patch (7.34 KB, patch)
2016-09-26 18:26 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (12.49 KB, patch)
2016-09-27 12:56 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-09-26 18:20:38 PDT
<rdar://problem/28486923>
Nan Wang
Comment 2 2016-09-26 18:21:01 PDT
<rdar://problem/26638734>
Nan Wang
Comment 3 2016-09-26 18:26:17 PDT
Created attachment 289898 [details] patch
chris fleizach
Comment 4 2016-09-27 11:02:17 PDT
Comment on attachment 289898 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=289898&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1240 > + String innerText = label->innerText(); seems like we should do the work to fetch this data if aria_Label is going to be used > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1243 > + if (!ariaLabel.isEmpty()) what if aria-labelledby is used on the label element
Nan Wang
Comment 5 2016-09-27 12:56:49 PDT
Created attachment 289999 [details] patch update from review. - Taken care of aria-labelledby on label elements - Added test cases
WebKit Commit Bot
Comment 6 2016-09-29 08:15:27 PDT
Comment on attachment 289999 [details] patch Clearing flags on attachment: 289999 Committed r206581: <http://trac.webkit.org/changeset/206581>
WebKit Commit Bot
Comment 7 2016-09-29 08:15:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.