Summary: | AX: Meter: [Mac] Content in label element should be used as AXTitle or AXDescription | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nan Wang <n_wang> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Nan Wang
2016-09-26 18:20:24 PDT
Created attachment 289898 [details]
patch
Comment on attachment 289898 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=289898&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1240 > + String innerText = label->innerText(); seems like we should do the work to fetch this data if aria_Label is going to be used > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1243 > + if (!ariaLabel.isEmpty()) what if aria-labelledby is used on the label element Created attachment 289999 [details]
patch
update from review.
- Taken care of aria-labelledby on label elements
- Added test cases
Comment on attachment 289999 [details] patch Clearing flags on attachment: 289999 Committed r206581: <http://trac.webkit.org/changeset/206581> All reviewed patches have been landed. Closing bug. |