Bug 162582

Summary: Modify testrunner to mute audio during tests
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, jer.noble, Ms2ger, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=163702
Bug Depends on: 172276, 174241    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2016-09-26 15:44:42 PDT
Modify testrunner to mute audio during tests
Attachments
Patch (1.85 KB, patch)
2016-10-19 12:15 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-09-26 16:48:26 PDT
I think that it already attempts to do this.
Jer Noble
Comment 2 2016-10-19 12:15:52 PDT
Created attachment 292092 [details] Patch
WebKit Commit Bot
Comment 3 2016-10-19 13:13:23 PDT
Comment on attachment 292092 [details] Patch Clearing flags on attachment: 292092 Committed r207561: <http://trac.webkit.org/changeset/207561>
WebKit Commit Bot
Comment 4 2016-10-19 13:13:27 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 5 2016-10-19 15:00:56 PDT
It looks like this caused platform/mac-wk2/plugins/muted-state.html to fail on mac-wk2 release bots: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r207563%20(768)/results.html
Jer Noble
Comment 6 2016-10-19 15:40:02 PDT
(In reply to comment #5) > It looks like this caused platform/mac-wk2/plugins/muted-state.html to fail > on mac-wk2 release bots: > > https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/ > r207563%20(768)/results.html That test is going to have to be modified so as to set the page into a known good state (unmuted) before the test starts.
Note You need to log in before you can comment on or make changes to this bug.