Bug 162574 – [WK2] Navigating to a Blob URL does not trigger a download

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Navigating to a Blob URL does not trigger a download.

Test Case: http://jsfiddle.net/cW7W5/1587/

The test case works as expected in Firefox and Chrome.

[Chris Dumez]

Created attachment 289892 [details]
WIP patch

[Chris Dumez]

Created attachment 289901 [details]
WIP Patch

[Chris Dumez]

Created attachment 289909 [details]
Patch

[Darin Adler]

Comment on attachment 289909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289909&action=review

This is OK for the short term, but probably not OK for the long term.

> Source/WebKit2/NetworkProcess/Downloads/BlobDownloadClient.cpp:47
> +    m_download.decideDestinationWithSuggestedFilenameAsync(m_download.suggestedName().isEmpty() ? "unknown" : m_download.suggestedName());

While this may be expedient, is not great that this special "filename" is an English word that is not localized. I suppose it’s a workaround for the fact that the client can’t handle no suggestion at all, but it does not seem like a good long term solution. Someone at Apple should think through how they want the Safari user interface to behave in cases like this. Then we should also think about how we want the WebKit API to behave; I can’t imagine we’d have wanted to pass a special string to mean no name suggested. After thinking this through, we should then do what is necessary to make sure we aren’t stuck with this forever.

[WebKit Commit Bot]

Comment on attachment 289909 [details]
Patch

Clearing flags on attachment: 289909

Committed r206439: <http://trac.webkit.org/changeset/206439>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.