Bug 162572

Summary: Web Inspector: Unfocusing / Focusing inspector window should not change ContentView
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Joseph Pecoraro
Reported 2016-09-26 12:20:58 PDT
Summary: Unfocusing / Focusing inspector window should not change ContentView Steps to Reproduce: 1. Inspect any page 2. Show Debugger Tab 3. Select a few different resources in sidebar 4. Click outside Inspector Window 5. Click back inside Inspector Window => Resource unexpectedly changed to the previous resource Notes: - This is almost certainly a regression.
Attachments
Patch (3.39 KB, patch)
2016-09-26 13:35 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (3.80 KB, patch)
2016-09-26 15:22 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-09-26 12:21:14 PDT
<rdar://problem/28479562>
Matt Baker
Comment 2 2016-09-26 12:38:39 PDT
This is being caused by the tree getting the focus, and reselecting the previously selected tree element.
Matt Baker
Comment 3 2016-09-26 13:35:12 PDT
Created attachment 289860 [details] Patch
Blaze Burg
Comment 4 2016-09-26 14:03:38 PDT
Comment on attachment 289860 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289860&action=review > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:654 > + previousSelectedTreeElement = previousSelectedTreeElement.traverseNextTreeElement(skipUnrevealed, this); If we are iterating forwards, then you should use a new variable name. I got confused. > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:-660 > - deselectedElement.treeOutline[WebInspector.NavigationSidebarPanel.PreviousSelectedTreeElementSymbol] = deselectedElement; It would be helpful to explain in the changelog why this is wrong. Is is because deselectedElement is null when the window gets focus?
Matt Baker
Comment 5 2016-09-26 15:22:35 PDT
Created attachment 289881 [details] Patch
Blaze Burg
Comment 6 2016-09-27 10:06:58 PDT
Comment on attachment 289881 [details] Patch r=me
WebKit Commit Bot
Comment 7 2016-09-27 10:27:59 PDT
Comment on attachment 289881 [details] Patch Clearing flags on attachment: 289881 Committed r206442: <http://trac.webkit.org/changeset/206442>
WebKit Commit Bot
Comment 8 2016-09-27 10:28:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.