Bug 162569

Summary: [GTK] TestContextMenu is failing
Product: WebKit Reporter: Tomas Popela <tpopela>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Description Tomas Popela 2016-09-26 11:13:31 PDT
The TestContextMenu unit test is failing with:

ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:316:virtual bool ContextMenuDefaultTest::contextMenu(WebKitContextMenu*, GdkEvent*, WebKitHitTestResult*): assertion failed: (webkit_hit_test_result_context_is_media(hitTestResult))

The cause is the type of audio source that we are using:

<audio style='position:absolute; left:1; top:60' width='50' height='20' controls='controls' preload='none'><source src='track.mp3' type='audio/mp3' /></audio>

We cannot use the MP3 file, as it will not work by default on most distributions (that don't have an MP3 codecs installed). Change the test to use OGG file instead.
Comment 1 Tomas Popela 2016-09-26 11:17:37 PDT
Created attachment 289839 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2016-09-26 11:58:16 PDT
Comment on attachment 289839 [details]
Proposed patch

Clearing flags on attachment: 289839

Committed r206382: <http://trac.webkit.org/changeset/206382>
Comment 3 WebKit Commit Bot 2016-09-26 11:58:20 PDT
All reviewed patches have been landed.  Closing bug.