Bug 162567 – Intermittent failures in ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js

• Component: JavaScriptCore
• Status: RESOLVED DUPLICATE

[Alexey Proskuryakov]

I've seen ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default fail more than once.

ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: DIFF FAILURE!
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: --- ../.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.baseline	2016-09-24 18:04:02.000000000 -0700
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: +++ ../ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default.out	2016-09-24 20:37:46.000000000 -0700
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: @@ -18,18 +18,18 @@
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  oa2[5]: { a: 101, b: 1, c: 2, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  oa2[6]: { a: 101, b: 1, c: 2, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  oa2[7]: { a: 101, b: 1, c: 2, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: -oa2[8]: { a: 101, b: 1, c: 2, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: +oa2[8]: { a: 0, b: 1, c: 2, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  Test 3:
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  oa3[0]: { a: 0, b: 1, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  oa3[1]: { a: 0, b: 1, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  oa3[2]: { a: 0, b: 1, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  oa3[3]: { a: 0, b: 1, p: 100, x: 102, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: -oa3[4]: { a: 0, b: 1, p: 100, x: 102, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: -oa3[5]: { a: 0, b: 1, p: 100, x: 102, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: -oa3[6]: { a: 0, b: 1, p: 100, x: 102, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: -oa3[7]: { a: 0, b: 1, p: 100, x: 102, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: -oa3[8]: { a: 0, b: 1, p: 100, x: 102, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: +oa3[4]: { a: 0, b: 1, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: +oa3[5]: { a: 0, b: 1, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: +oa3[6]: { a: 0, b: 1, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: +oa3[7]: { a: 0, b: 1, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default: +oa3[8]: { a: 0, b: 1, p: 100, x: 10, y: 11 }
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  Test 4:
ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default:  oa4[0]: { a: 100, b: 101, c: 102, i: 108, j: 109, p: 200, x: 110, y: 111 }
FAIL: ChakraCore.yaml/ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js.default

[Radar WebKit Bug Importer]

<rdar://problem/28476667>

[Mark Lam]

*** Bug 165064 has been marked as a duplicate of this bug. ***

[Mark Lam]

This test is not flaky.  There appears to be an intermittent bug that is causing the test failure.

[Alexey Proskuryakov]

When we say "flaky test", that doesn't imply that the test is broken. A much more common cause of flakyness is bugs in WebKit.

[Alexey Proskuryakov]

*** Bug 163692 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 163847 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

The test fails fairly frequently (right now, both debug and release bots are red because of it). A fix would be highly appreciated.

[Ryan Haddad]

Created attachment 295908 [details]
Skip the test

Patch to skip the test.

[Saam Barati]

Comment on attachment 295908 [details]
Skip the test

r=me

[Ryan Haddad]

Comment on attachment 295908 [details]
Skip the test

Clearing flags on attachment: 295908

Committed r209219: <http://trac.webkit.org/changeset/209219>

[Saam Barati]

My hypothesis for what the bug is is that we're failing to register for some watchpoint inside the DFG inside the bytecode parser when we optimize create_this to lower to NewObject instead of CreateThis

[Michael Saboff]

Opened a new bug for the underlying problem <https://bugs.webkit.org/show_bug.cgi?id=173321> - "DFG doesn't properly handle a property that is change to read only in a prototype"

Fixed the issue in change set r218203: <http://trac.webkit.org/changeset/218203>

[Michael Saboff]

*** This bug has been marked as a duplicate of bug 173321 ***