Summary: | std::unique_ptr deleter functions should not check if pointer is null | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Trivial | CC: | bugs-noreply, commit-queue, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2016-09-26 07:22:03 PDT
Created attachment 289828 [details]
Patch
Comment on attachment 289828 [details]
Patch
This is good.
I feel like we could add another template parameter somewhere with the deleter function and unify all of these and the CairoUniquePtr into one template.
Comment on attachment 289828 [details]
Patch
Hm, maybe... not in this patch though!
Comment on attachment 289828 [details] Patch Clearing flags on attachment: 289828 Committed r206377: <http://trac.webkit.org/changeset/206377> All reviewed patches have been landed. Closing bug. |