[GTK] Require implementation of cpuDescriptionForUAString

• Component: WebKitGTK
• Status: RESOLVED WONTFIX

[Michael Catanzaro]

Require implementation of cpuDescriptionForUAString. Less-popular architectures would probably prefer to get a nice build error here than to wind up with a broken user agent.

[Michael Catanzaro]

Created attachment 289809 [details]
Patch

[Carlos Garcia Campos]

Is this ok for distros like debian that build on different platforms?

[Carlos Alberto Lopez Perez]

(In reply to comment #0)
> Require implementation of cpuDescriptionForUAString. Less-popular
> architectures would probably prefer to get a nice build error here than to
> wind up with a broken user agent.


Why is having the CPU architecture relevant for a webpage to work or not? 

Why we don't just return "Intel" instead of "unknown" or causing an unneeded build failure?

[Michael Catanzaro]

(In reply to comment #2)
> Is this ok for distros like debian that build on different platforms?

I suggest we simply accept patches to add more conditionals here from people working on alternative architectures. If we know how to test for them (I don't) then we could do that now instead of waiting for patches to roll in.

(In reply to comment #3)
> Why we don't just return "Intel" instead of "unknown" or causing an unneeded
> build failure?

I guess we could, but is it really so hard to implement one function when using WebKit on a brand new architecture? This seems quite easy relative to other arch-enablement that might be required.

[Carlos Alberto Lopez Perez]

(In reply to comment #4)
> (In reply to comment #2)
> > Is this ok for distros like debian that build on different platforms?
> 
> I suggest we simply accept patches to add more conditionals here from people
> working on alternative architectures. If we know how to test for them (I
> don't) then we could do that now instead of waiting for patches to roll in.
> 
> (In reply to comment #3)
> > Why we don't just return "Intel" instead of "unknown" or causing an unneeded
> > build failure?
> 
> I guess we could, but is it really so hard to  implement one function when
> using WebKit on a brand new architecture? This seems quite easy relative to
> other arch-enablement that might be required.

The thing is that returning "RISC-V" or "MIPS" is as bad as returning "Unknown".
If the goal is to have sites working on this architectures as best as possible we should just return "Intel" always, because is what sites expect to find.

I don't think a site can have architecture-specific html/css/javascript. So just return Intel instead of Unknown.

UA parsing is broken, so we can't do much about this than returning the more common possible UA string.

[Michael Catanzaro]

Yeah OK.

I wonder if we should do this for ARM too. In Endless we've found that various sites send mobile versions if ARM is in the UA, which is terrible.

[Carlos Alberto Lopez Perez]

(In reply to comment #6)
> Yeah OK.
> 
> I wonder if we should do this for ARM too. In Endless we've found that
> various sites send mobile versions if ARM is in the UA, which is terrible.

Yes, i think so.  Returning "Intel" always without giving further details about the machine CPU architecture looks like a good idea to me.

[Zan Dobersek]

(In reply to comment #7)
> (In reply to comment #6)
> > Yeah OK.
> > 
> > I wonder if we should do this for ARM too. In Endless we've found that
> > various sites send mobile versions if ARM is in the UA, which is terrible.
> 
> Yes, i think so.  Returning "Intel" always without giving further details
> about the machine CPU architecture looks like a good idea to me.

IMO this also helps with improving fingerprinting avoidance.