Bug 162532

Summary: AuthorStyleSheets shouldn't trigger synchronous style resolutions
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
darin: review+
patch none

Antti Koivisto
Reported 2016-09-24 10:04:40 PDT
AuthorStyleSheets logic can be simplified. This should be done by the client if needed.
Attachments
patch (31.42 KB, patch)
2016-09-24 10:29 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (37.35 KB, patch)
2016-09-24 11:50 PDT, Antti Koivisto 		darin: review+
DetailsFormatted DiffDiff
patch (37.70 KB, patch)
2016-09-25 05:25 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-09-24 10:29:56 PDT
Created attachment 289746 [details] patch
Antti Koivisto
Comment 2 2016-09-24 11:50:46 PDT
Created attachment 289748 [details] patch
Darin Adler
Comment 3 2016-09-24 17:57:44 PDT
Comment on attachment 289748 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=289748&action=review > Source/WebCore/dom/AuthorStyleSheets.h:66 > + enum class ChangeType { ActiveSet, ContentsOrInterpretation }; > + WEBCORE_EXPORT void didChange(ChangeType); Does this really need to be a single function call with an argument? It’s kind of wordy to call it that way. Maybe we should make this two different named functions. They can share code inside the class and we can use the ChangeType f we find it handy internally, but I suspect there is no real advantage to callers that this is an argument rather than a separate function.
Antti Koivisto
Comment 4 2016-09-25 04:38:58 PDT
Yeah, that was the plan though you right that I can as well do it in this patch.
Antti Koivisto
Comment 5 2016-09-25 05:25:40 PDT
Created attachment 289776 [details] patch
WebKit Commit Bot
Comment 6 2016-09-25 06:34:43 PDT
Comment on attachment 289776 [details] patch Clearing flags on attachment: 289776 Committed r206361: <http://trac.webkit.org/changeset/206361>
WebKit Commit Bot
Comment 7 2016-09-25 06:34:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.