Bug 16252
| Summary: | build-webkit --clean should remove generated files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, emw, ryanhaddad |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
Adam Roben (:aroben)
build-webkit --clean on Windows does not remove some of the generated files the build creates, such as the files generated by gperf. See bug 16210 for one instance where this caused problems for someone.
It's possible we could fix this by adding all the generated files to the .vcproj.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Matt Lilek
Is there any reason that build-webkit doesn't see --clean and just blow away the entire WebKitBuild directory?
Mark Rowe (bdash)
Matt, it's sometimes desirable to clean only the debug or release configuration, leaving the other intact.
Brian Campbell
It appears that build-webkit --clean also doesn't delete generated files on the Mac.
I spent a while trying to hunt a problem down with build-webkit --filters, until I realized that the build-webkit --clean that I had run hadn't deleted WebKitBuild/Release/DerivedSources/WebCore/SVGNames.{cpp,h}.
Ahmad Saleem
Is this needed anymore? Thanks!
Alexey Proskuryakov
For both Xcode and Visual Studio, build-webkit implements cleaning by passing an option to xcodebuild or MSBuild.
I don't know if any generated files are missed when cleaning now. Wouldn't be surprised if this was still broken.