Summary: | [Binding] Use uncheckedArgument if argumentCount is already checked | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | Bindings | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, fpizlo, ggaren, saam, sam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2016-09-23 12:26:53 PDT
This and https://bugs.webkit.org/show_bug.cgi?id=162503 patches offers roughly 5% perf win in dromaeo dom-attr's getAttribute / setAttribute. Created attachment 289716 [details]
Patch
Comment on attachment 289716 [details]
Patch
r=me
Comment on attachment 289716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289716&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4031 > + my $argumentLookupMethod = "argument"; Would be nice as a ternary: my $argumentLookupMethod = $parameter->isOptional ? "argument" : "uncheckedArgument"; > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4072 > + my $argumentLookupMethod = "argument"; Ditto. Comment on attachment 289716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289716&action=review Thanks for your reviews! >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4031 >> + my $argumentLookupMethod = "argument"; > > Would be nice as a ternary: > my $argumentLookupMethod = $parameter->isOptional ? "argument" : "uncheckedArgument"; Nice, fixed. >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4072 >> + my $argumentLookupMethod = "argument"; > > Ditto. Fixed. Committed r206338: <http://trac.webkit.org/changeset/206338> (In reply to comment #1) > This and https://bugs.webkit.org/show_bug.cgi?id=162503 patches offers > roughly 5% perf win in dromaeo dom-attr's getAttribute / setAttribute. Awesome! |