Bug 16250

Summary: Implement Element.all (http://news.vnet.cn : Mouse hover on tabs not working)
Product: WebKit Reporter: Anantha Keesara <anantha>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: andersca, jwalden+bwo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://news.vnet.cn
Description Flags
Patch eric: review-

Description Anantha Keesara 2007-12-02 09:00:07 PST
Steps: Mouse over on tabs below flash image, with 1 2 3, on left side of the page.

Issue: The tab content doesn't change.

IE and Opera gets it right.

Tested with: WebKit-SVN-r28278
Comment 1 Anantha Keesara 2007-12-02 09:02:07 PST
Created attachment 17647 [details]
Comment 2 Alexey Proskuryakov 2007-12-03 02:40:59 PST
Confirmed. We only have document.all, HTML elements do not implement all() in WebKit.
Comment 3 Alexey Proskuryakov 2007-12-03 02:41:10 PST
Comment 4 Maciej Stachowiak 2008-01-14 05:43:29 PST
Should Element.all be hidden, like Document.all?
Comment 5 Eric Seidel (no email) 2008-01-14 09:30:01 PST
I'm no expert in the area.  But I would suggest we hide it.  There is no sense in advertising our being more like IE.  Element.all only needs to exist for compat with sites which only assume IE (and are currently completely broken on all non-IE browsers).

We already have the code to make a hidden property, we can just reuse the stuff for Document.all.
Comment 6 Jeff Walden (remove +bwo to email) 2008-01-19 15:45:04 PST
Catfish_Man asks me to note this here:

While I'm thinking about it, I remember hearing that Mozilla got asked to implement Element.all but didn't see the need and were attempting to hold the line on that particular IEism; webkit implementing doesn't help that.  :-\
Comment 7 David Smith 2008-01-19 16:16:51 PST
Created attachment 18557 [details]

The full .all feature is pretty weird, according to Microsoft's documentation. This reuses what we have for document.all, which is enough to make the tabs on news.vnet.cn work.
Comment 8 Eric Seidel (no email) 2008-01-21 23:39:55 PST
Comment on attachment 18557 [details]

So I think this patch is fine.  The only thing missing is test cases. :)

r- until we add at least one element.all test case! :)  The test that it's undetectable is nice, but doesn't really test the feature. :)