Summary: | DumpRenderTree crashed in com.apple.WebCore: WTF::Optional<WebCore::FetchBodyOwner::BlobLoader>::operator bool const + 12 | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, ddkilzer, ryanhaddad, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
youenn fablet
2016-09-23 01:29:59 PDT
Created attachment 289671 [details]
Patch
Is this rdar://problem/28438651? (In reply to comment #2) > Is this rdar://problem/28438651? Yes Comment on attachment 289671 [details]
Patch
I see three options here:
1. Remove the assert (which ensures that we correctly unset pending request)
2. Protect the body owner but this is not very useful in release
3. Protect the body owner in debug mode but that makes a difference with release, which may be also annoying.
I chose option 3 but could also go with option 1
Created attachment 289944 [details]
Patch
Created attachment 290081 [details]
Patch
Comment on attachment 290081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290081&action=review > Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:61 > + ASSERT(isUniqueReference || !m_blobLoader); ASSERT_UNUSED would make this cleaner. Created attachment 290307 [details]
Patch for landing
Comment on attachment 290307 [details] Patch for landing Rejecting attachment 290307 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: _64/FloatPolygon.dia -c /Volumes/Data/EWS/WebKit/Source/WebCore/platform/graphics/FloatPolygon.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/FloatPolygon.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/FetchBodyOwner.o Modules/fetch/FetchBodyOwner.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/2173332 Created attachment 290309 [details]
Patch for landing
Comment on attachment 290309 [details] Patch for landing Clearing flags on attachment: 290309 Committed r206633: <http://trac.webkit.org/changeset/206633> All reviewed patches have been landed. Closing bug. |