Bug 162467

Summary:

Replace redundant prepareForDestruction() call with RELEASE_ASSERT in Document::removedLastRef.

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dbates, esprehn+autocc, kangil.han

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cdumez: review+, buildbot: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Patch	cdumez: review+

alan

Reported 2016-09-22 15:01:36 PDT

prepareForDestruction() was a workaround to fix bug 159372. However since r205786 fixed the root cause, we no longer need the workaround. Just add a RELEASE_ASSERT check to ensure clean state.

Attachments
Patch (1.59 KB, patch) 2016-09-22 15:06 PDT, alan	cdumez: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 (16.08 MB, application/zip) 2016-09-22 15:54 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-yosemite (1.25 MB, application/zip) 2016-09-22 15:57 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (2.03 MB, application/zip) 2016-09-22 15:59 PDT, Build Bot	no flags	Details
Patch (1.58 KB, patch) 2016-09-22 18:58 PDT, alan	cdumez: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2016-09-22 15:06:47 PDT

Created attachment 289610 [details] Patch

Chris Dumez

Comment 2 2016-09-22 15:08:56 PDT

Comment on attachment 289610 [details] Patch r=me if the tests are happy.

Build Bot

Comment 3 2016-09-22 15:54:35 PDT

Comment on attachment 289610 [details] Patch Attachment 289610 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2128093 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2016-09-22 15:54:40 PDT

Created attachment 289620 [details] Archive of layout-test-results from ews125 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2016-09-22 15:57:40 PDT

Comment on attachment 289610 [details] Patch Attachment 289610 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2128166 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2016-09-22 15:57:45 PDT

Created attachment 289621 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-09-22 15:59:41 PDT

Comment on attachment 289610 [details] Patch Attachment 289610 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2128173 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2016-09-22 15:59:46 PDT

Created attachment 289622 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

alan

Comment 9 2016-09-22 18:58:11 PDT

Created attachment 289645 [details] Patch

alan

Comment 10 2016-09-23 07:19:15 PDT

Committed r206299: <http://trac.webkit.org/changeset/206299>

Note You need to log in before you can comment on or make changes to this bug.