Bug 16236

Summary:

Inspector should highlight all nodes found when searching

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

timothy

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

17777

Attachments:

Description	Flags
[WIP] Pass an array of nodes to InspectorController.highlightDOMNode	none
[WIP] highlight all found nodes when searching	none

Adam Roben (:aroben)

Reported 2007-12-01 23:04:51 PST

The Inspector should highlight all the nodes found when searching, similar to the way Safari 3 highlights all text matches when searching. The focused node should have a distinct highlight to distinguish it from the other highlighted nodes.

Attachments
[WIP] Pass an array of nodes to InspectorController.highlightDOMNode (10.40 KB, patch) 2008-03-19 16:28 PDT, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
[WIP] highlight all found nodes when searching (3.54 KB, patch) 2008-03-19 16:29 PDT, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2008-01-29 11:05:42 PST

<rdar://problem/5712865>

Adam Roben (:aroben)

Comment 2 2008-03-19 16:28:50 PDT

Created attachment 19889 [details] [WIP] Pass an array of nodes to InspectorController.highlightDOMNode Not for review yet.

Adam Roben (:aroben)

Comment 3 2008-03-19 16:29:11 PDT

Created attachment 19890 [details] [WIP] highlight all found nodes when searching Not for review yet.

Timothy Hatcher

Comment 4 2008-09-24 01:29:38 PDT

We highlight the nodes in the DOM tree now (not the page). I think this is a better design, since we don't always have a highlight over the page like before. Landed in r36834.

Note You need to log in before you can comment on or make changes to this bug.