Bug 162357

Summary:

support openPaymentSetup API on ApplePaySession object

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dbates, esprehn+autocc, japhet, kondapallykalyan, mkwst, ossy, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Anders Carlsson 2016-09-21 13:44:18 PDT

support openPaymentSetup API on ApplePaySession object

Comment 1 Anders Carlsson 2016-09-21 13:54:25 PDT

Created attachment 289475 [details]
Patch

Comment 2 WebKit Commit Bot 2016-09-21 13:55:31 PDT

Attachment 289475 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:226:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:45:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:94:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:59:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:98:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/loader/EmptyClients.cpp:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 11 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Tim Horton 2016-09-21 15:38:02 PDT

Comment on attachment 289475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289475&action=review

> Source/WebCore/ChangeLog:11
> +        Perform security checks and then call into the PaymentCoordiantor. In its completion handler, we resolve the promise.

COORDINATOR

> Source/WebCore/Modules/applepay/ApplePaySession.cpp:779
> +        window.printErrorMessage("Must call ApplePaySession.openPaymemntSetup from a user gesture handler.");

PAYMENT

Comment 4 Anders Carlsson 2016-09-21 15:54:07 PDT

Committed r206238: <http://trac.webkit.org/changeset/206238>

Comment 5 Csaba Osztrogonác 2016-09-21 22:27:49 PDT

(In reply to comment #4)
> Committed r206238: <http://trac.webkit.org/changeset/206238>

One of the unreviewed fix after this patch broke the iOS build:
https://build.webkit.org/builders/Apple%20iOS%2010%20Release%20%28Build%29/builds/189

Comment 6 Csaba Osztrogonác 2016-09-22 09:00:57 PDT

just to document, fixed by https://trac.webkit.org/changeset/206258