Bug 162339

Summary: [Fetch API] Remove ReadableStreamSource firstReadCallback
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, calvaris, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2016-09-21 08:41:54 PDT
This callback was used to ensure body was not disturbed until the stream gets read. This is handled more properly now, so we should remove this callback. This should allow us in the end to buffer data within FetchResponse until the stream actually wants to be feeded. That information could be useful in the future if we want to apply back pressure somehow to the network layer.
Attachments
Patch (10.92 KB, patch)
2016-09-21 08:48 PDT, youenn fablet
no flags
Patch for landing (10.94 KB, patch)
2016-09-27 01:17 PDT, youenn fablet
no flags
youenn fablet
Comment 1 2016-09-21 08:48:46 PDT
WebKit Commit Bot
Comment 2 2016-09-27 00:39:30 PDT
Comment on attachment 289454 [details] Patch Rejecting attachment 289454 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 289454, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e.h patching file Source/WebCore/Modules/streams/ReadableStreamSource.idl patching file Source/WebCore/bindings/js/JSReadableStreamSourceCustom.cpp Hunk #1 FAILED at 35. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/js/JSReadableStreamSourceCustom.cpp.rej patching file Source/WebCore/bindings/js/WebCoreBuiltinNames.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2153102
youenn fablet
Comment 3 2016-09-27 01:17:09 PDT
Created attachment 289923 [details] Patch for landing
WebKit Commit Bot
Comment 4 2016-09-27 01:50:03 PDT
Comment on attachment 289923 [details] Patch for landing Clearing flags on attachment: 289923 Committed r206423: <http://trac.webkit.org/changeset/206423>
WebKit Commit Bot
Comment 5 2016-09-27 01:50:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.