Bug 16227
| Summary: | [WIN] JavaScriptCore should export API using JS_EXPORT | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alp Toker <alp> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aroben, darin, ggaren, hausmann, sfalken |
| Priority: | P2 | Keywords: | PlatformOnly |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
Alp Toker
The patch in http://bugs.webkit.org/show_bug.cgi?id=15569 introduced JS_EXPORT to export public API without defs file entries in r28097.
It was backed out in r28100 because we couldn't figure out how to define JS_BUILDING_JS in the windows build system (which is required by MSVC to decide between dllimport and dllexport). Once this is done, r28100 should be re-introduced and redundant entries removed from the Win defs file.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Steve Falkenburg
This is fixed in r42680 for the Windows build. The change requires proper definition of a BUILDING_{projectname} preprocessor def. We have this defined in win/tools/vsprops/common.vsprops.
Darin Adler
There’s still a comment with this bug number in it in JSBase.h. What should we do about that?
Steve Falkenburg
I'll remove the comment.