Bug 16226
Summary: | Poster frame stops displaying once video loads, even if it does not play | ||
---|---|---|---|
Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> |
Component: | Layout and Rendering | Assignee: | Adele Peterson <adele> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | dwood, eric.carlson, gavin.sharp, lachlan.hunt |
Priority: | P2 | Keywords: | HasReduction, InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | Mac | ||
OS: | OS X 10.4 |
Maciej Stachowiak
The poster="" specified poster frame should display until the video first plays, not just until it loads. The linked test case appears to show that we switch from the 'poster' attribute to the video's actual poster frame as soon as it loads.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Maciej Stachowiak
Test case forthcoming.
Maciej Stachowiak
http://lachy.id.au/dev/markup/tests/html5/video/007
http://lachy.id.au/dev/markup/tests/html5/video/008
Adele Peterson
The implementation is based on this line from the spec:
"When no video data is available (the element's networkState attribute is either EMPTY, LOADING, or LOADED_METADATA), video elements represent either the image given by the poster attribute, or nothing."
David Kilzer (:ddkilzer)
<rdar://problem/5650561>
Ian 'Hixie' Hickson
The spec now allows the poster frame to be shown instead of the first frame of video while the video is paused on the first frame of video (though it doesn't require it).
Adele Peterson
Lets say an author specifies something like this:
<video src="myVideo.mp4" poster="myImage.png" controls></video>
Adele Peterson
shoot- I hit enter by accident.
With the example above and our current implementation, if I make the change to keep the poster image up if the video is paused on the first frame, thne the controls aren't visible for the user to actually start playing the video. To fix this, I could rearrange RenderVideo so it owns the renderer for the poster image, and have it still display the controls over the poster image. I'm not sure if I'm missing something else though that would prevent this from working correctly.
Eric Carlson
This was fixed by the changes in http://trac.webkit.org/changeset/53146.