Bug 162255

Summary: VideoControlsManager.VideoControlsManagerSingleLargeVideo fails intermittently on the Mac WK2 bot
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: MediaAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Description Wenson Hsieh 2016-09-19 22:13:17 PDT 
VideoControlsManager.VideoControlsManagerSingleLargeVideo fails intermittently on the Mac WK2 bot

This is reproducible by running the test repeatedly in a for loop (locally, I observed that running the test back-to-back would result in the second one failing). This suggests that even on the runloop after the video starts playing, the state of the playback controls manager may not be up to date in the UI process. Instead, we can just spin the runloop until the playback controls are shown, which makes back-to-back tests to succeed and will probably address flakiness on the bots for this test.
Comment 1 Wenson Hsieh 2016-09-19 22:15:15 PDT 
Created attachment 289320 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-19 22:16:17 PDT 
Attachment 289320 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Wenson Hsieh 2016-09-19 22:17:37 PDT 
Created attachment 289321 [details]
Patch
Comment 4 Jer Noble 2016-09-19 23:12:23 PDT 
Comment on attachment 289321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289321&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:9
> +<body onload=play()>

Nit: shouldn't this have quotes?
Comment 5 Wenson Hsieh 2016-09-20 08:07:50 PDT 
Comment on attachment 289321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289321&action=review

>> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:9
>> +<body onload=play()>
> 
> Nit: shouldn't this have quotes?

Ok! Added quotes.
Comment 6 Wenson Hsieh 2016-09-20 08:13:50 PDT 
Created attachment 289346 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2016-09-20 08:14:38 PDT 
Comment on attachment 289346 [details]
Patch for landing

Rejecting attachment 289346 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 289346, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2112643
Comment 8 Wenson Hsieh 2016-09-20 08:16:30 PDT 
Created attachment 289347 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2016-09-20 08:49:25 PDT 
Comment on attachment 289347 [details]
Patch for landing

Clearing flags on attachment: 289347

Committed r206148: <http://trac.webkit.org/changeset/206148>
Comment 10 WebKit Commit Bot 2016-09-20 08:49:29 PDT 
All reviewed patches have been landed.  Closing bug.