Bug 16218

Summary: [GTK] API: Should this entry point be called go_back rather than go_backward?
Product: WebKit Reporter: Alp Toker <alp>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: christian
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
go_back patch
none
API fix and documentation
none
Fixed comments; better obsolete messages mrowe: review+

Alp Toker
Reported 2007-11-30 20:33:33 PST
go_back() is the de-facto standard in the browser world. The GTK+ port instead provides go_backward(), presumably to remain consistent with the corresponding de-facto go_forward() Browsers usually have "Back" and "Forward" buttons. However GTK+ developers have a history of breaking popular conventions in favour of grammatical consistency or a strong conviction of "correctness" (eg. URI vs URL). Do we want to stick with what we have or follow the crowd? This is relevant to WebKitWebView and possibly WebKitWebFrame and other classes. Christian originally raised this question but hasn't yet written up the bug so I went ahead and did so.
Attachments
go_back patch (1.87 KB, patch)
2007-12-02 03:10 PST, Jan Alonzo 		no flags
DetailsFormatted DiffDiff
API fix and documentation (7.51 KB, patch)
2008-01-16 05:47 PST, Alp Toker 		no flags
DetailsFormatted DiffDiff
Fixed comments; better obsolete messages (7.49 KB, patch)
2008-01-16 18:18 PST, Alp Toker 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2007-12-02 03:10:45 PST
Created attachment 17640 [details] go_back patch I prefer "go back" because I want to be part of the crowd :) and also because WebView of the Mac and Win ports also use "go back" in their API. I've attached a patch to use go_back instead of go_backward. It's not for review until there's a decision about the API.
Alp Toker
Comment 2 2008-01-16 05:47:17 PST
Created attachment 18471 [details] API fix and documentation New symbols added, old symbols deprecated.
Alp Toker
Comment 3 2008-01-16 18:18:04 PST
Created attachment 18486 [details] Fixed comments; better obsolete messages
Alp Toker
Comment 4 2008-01-16 18:28:14 PST
Landed in r29550.
Note You need to log in before you can comment on or make changes to this bug.