Summary: | Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
Component: | CSS | Assignee: | Daniel Bates <dbates> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aestes, cgarcia, gyuyoung.kim, koivisto, mcatanzaro, simon.fraser | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Daniel Bates
2016-09-19 10:42:42 PDT
Created attachment 289240 [details]
Patch
Assuming it is acceptable to remove the ENABLE(TEXT_AUTOSIZING) code. Then I will close bug #84186 and all its child bugs as Resolved Invalid (is a more appropriate status to use?). I would use Resolved Wontfix, but it doesn't matter much. Created attachment 289248 [details]
Patch
Revert inadvertent removal of files TextAutosizing.{cpp, h} from the WebCore Xcode project. These files are used by the iOS automatic text size adjustment code.
Comment on attachment 289248 [details] Patch Attachment 289248 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2107456 New failing tests: fast/text-autosizing/ios/line-height-text-autosizing.html Created attachment 289254 [details]
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.6
Committed r206119: <http://trac.webkit.org/changeset/206119> (In reply to comment #5) > Comment on attachment 289248 [details] > Patch > > Attachment 289248 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/2107456 > > New failing tests: > fast/text-autosizing/ios/line-height-text-autosizing.html I updated LayoutTests/platform/ios-simulator/TestExpectations to mark this test as Failure before landing the patch for this bug. This test began failing with attachment #289248 [details] because I removed the Failure entry for fast/text-autosizing/ios/line-height-text-autosizing.html from the WK1/WK2 TestExpectations. I filed bug #162236 to investigate the failure of this test on iOS. |