Bug 162114

Summary: Web Inspector: Bring the inspected page's window forward when activating element search
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2016-09-16 22:58:59 PDT 
Summary:
Bring the inspected page's window forward when activating element search.

When using a detached inspector is annoying that after enabling node search you have to make multiple clicks. (1) To focus the window containing the inspected page and (2) to then select the node. We should eliminate click (1) which often confuses people. This would also make ⇧⌘C also bring the inspected page forward for very fast selecting of different elements.
Comment 1 Radar WebKit Bug Importer 2016-09-16 22:59:16 PDT 
<rdar://problem/28349357>
Comment 2 Joseph Pecoraro 2016-09-16 23:01:10 PDT 
Created attachment 289162 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-09-19 02:20:25 PDT 
Comment on attachment 289162 [details]
[PATCH] Proposed Fix

r=me

Does this work correctly from the API / menu item as well?
Comment 4 WebKit Commit Bot 2016-09-19 02:42:07 PDT 
Comment on attachment 289162 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 289162

Committed r206091: <http://trac.webkit.org/changeset/206091>
Comment 5 WebKit Commit Bot 2016-09-19 02:42:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2016-09-22 11:46:23 PDT 
(In reply to comment #3)
> Comment on attachment 289162 [details]
> [PATCH] Proposed Fix
> 
> r=me
> 
> Does this work correctly from the API / menu item as well?

Yes, in all cases. Menu item, keyboard shortcut, frontend toolbar icon / protocol API.