Bug 162107

Summary: Web Replay: teach the replay inputs generator to encode and decode OptionSet<T>
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bburg, commit-queue, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix none

Blaze Burg
Reported 2016-09-16 17:29:46 PDT
Hehe.
Attachments
Proposed Fix (29.45 KB, patch)
2016-09-16 17:47 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2016-09-16 17:47:35 PDT
Created attachment 289152 [details] Proposed Fix
WebKit Commit Bot
Comment 2 2016-09-16 17:50:13 PDT
This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)
WebKit Commit Bot
Comment 3 2016-09-16 17:50:22 PDT
Attachment 289152 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h:75: "virtual" is redundant since function is already declared as "final" [readability/inheritance] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 4 2016-09-19 10:18:45 PDT
Comment on attachment 289152 [details] Proposed Fix Clearing flags on attachment: 289152 Committed r206099: <http://trac.webkit.org/changeset/206099>
WebKit Commit Bot
Comment 5 2016-09-19 10:18:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.