Bug 162094

Summary: Cancelling one frame's load cancels load in other frames that have the same URL as well
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, dbates, hyongyoub.kim, japhet, koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews116 for mac-yosemite
none
Patch none

Description Chris Dumez 2016-09-16 15:30:41 PDT 
Cancelling one frame's load cancels load in other frames that have the same URL as well.

So if you have several frames that are loading URL X and you navigate one of the frames to Y, then the load of X will be cancelled and this frame will navigate to Y. All other frames will not load URL X even though they should.

Firefox and Chrome do not have this problem.
Comment 1 Chris Dumez 2016-09-16 15:42:40 PDT 
Created attachment 289120 [details]
Patch
Comment 2 Antti Koivisto 2016-09-16 15:46:51 PDT 
Comment on attachment 289120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289120&action=review

> Source/WebCore/ChangeLog:21
> +        I sitll chose this approach because:

typo "sitll"
Comment 3 Chris Dumez 2016-09-16 15:54:13 PDT 
Created attachment 289124 [details]
Patch
Comment 4 Alex Christensen 2016-09-16 15:59:42 PDT 
Is this a duplicate of https://bugs.webkit.org/show_bug.cgi?id=157563 ?  Does it fix that? Would adding the test from that bug be useful?
Comment 5 Chris Dumez 2016-09-16 16:18:12 PDT 
(In reply to comment #4)
> Is this a duplicate of https://bugs.webkit.org/show_bug.cgi?id=157563 ? 
> Does it fix that? Would adding the test from that bug be useful?

The test you have on the other bug (http/tests/cache/iframe-detach.html) seems to pass with my change.
Comment 6 Chris Dumez 2016-09-16 16:20:49 PDT 
Created attachment 289127 [details]
Patch
Comment 7 Chris Dumez 2016-09-16 16:24:29 PDT 
*** Bug 157563 has been marked as a duplicate of this bug. ***
Comment 8 Build Bot 2016-09-16 17:12:13 PDT 
Comment on attachment 289127 [details]
Patch

Attachment 289127 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2090964

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-09-16 17:12:17 PDT 
Created attachment 289146 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Chris Dumez 2016-09-16 18:18:13 PDT 
Created attachment 289153 [details]
Patch
Comment 11 WebKit Commit Bot 2016-09-16 20:20:55 PDT 
Comment on attachment 289153 [details]
Patch

Clearing flags on attachment: 289153

Committed r206062: <http://trac.webkit.org/changeset/206062>
Comment 12 WebKit Commit Bot 2016-09-16 20:21:01 PDT 
All reviewed patches have been landed.  Closing bug.