Bug 162094

Summary: Cancelling one frame's load cancels load in other frames that have the same URL as well
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, dbates, hyongyoub.kim, japhet, koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews116 for mac-yosemite
none
Patch none

Chris Dumez
Reported 2016-09-16 15:30:41 PDT
Cancelling one frame's load cancels load in other frames that have the same URL as well. So if you have several frames that are loading URL X and you navigate one of the frames to Y, then the load of X will be cancelled and this frame will navigate to Y. All other frames will not load URL X even though they should. Firefox and Chrome do not have this problem.
Attachments
Patch (7.33 KB, patch)
2016-09-16 15:42 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.47 KB, patch)
2016-09-16 15:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.32 KB, patch)
2016-09-16 16:20 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews116 for mac-yosemite (912.91 KB, application/zip)
2016-09-16 17:12 PDT, Build Bot 		no flags
Details
Patch (9.32 KB, patch)
2016-09-16 18:18 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-09-16 15:42:40 PDT
Created attachment 289120 [details] Patch
Antti Koivisto
Comment 2 2016-09-16 15:46:51 PDT
Comment on attachment 289120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289120&action=review > Source/WebCore/ChangeLog:21 > + I sitll chose this approach because: typo "sitll"
Chris Dumez
Comment 3 2016-09-16 15:54:13 PDT
Created attachment 289124 [details] Patch
Alex Christensen
Comment 4 2016-09-16 15:59:42 PDT
Is this a duplicate of https://bugs.webkit.org/show_bug.cgi?id=157563 ? Does it fix that? Would adding the test from that bug be useful?
Chris Dumez
Comment 5 2016-09-16 16:18:12 PDT
(In reply to comment #4) > Is this a duplicate of https://bugs.webkit.org/show_bug.cgi?id=157563 ? > Does it fix that? Would adding the test from that bug be useful? The test you have on the other bug (http/tests/cache/iframe-detach.html) seems to pass with my change.
Chris Dumez
Comment 6 2016-09-16 16:20:49 PDT
Created attachment 289127 [details] Patch
Chris Dumez
Comment 7 2016-09-16 16:24:29 PDT
*** Bug 157563 has been marked as a duplicate of this bug. ***
Build Bot
Comment 8 2016-09-16 17:12:13 PDT
Comment on attachment 289127 [details] Patch Attachment 289127 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2090964 Number of test failures exceeded the failure limit.
Build Bot
Comment 9 2016-09-16 17:12:17 PDT
Created attachment 289146 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Chris Dumez
Comment 10 2016-09-16 18:18:13 PDT
Created attachment 289153 [details] Patch
WebKit Commit Bot
Comment 11 2016-09-16 20:20:55 PDT
Comment on attachment 289153 [details] Patch Clearing flags on attachment: 289153 Committed r206062: <http://trac.webkit.org/changeset/206062>
WebKit Commit Bot
Comment 12 2016-09-16 20:21:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.