Summary: | Text nodes assigned to a linked slot are not clickable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jan Miksovsky <jan> | ||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari Technology Preview | ||||||||
Hardware: | Unspecified | ||||||||
OS: | OS X 10.11 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 148695 | ||||||||
Attachments: |
|
Description
Jan Miksovsky
2016-09-16 14:27:25 PDT
Created attachment 290153 [details]
Fixes the bug
Created attachment 290159 [details]
Fixes the bug
Comment on attachment 290159 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=290159&action=review > Source/WebCore/dom/Node.cpp:1845 > - for (Node* node = this; node; node = node->parentOrShadowHostNode()) { > + for (Node* node = this; node; node = node->parentInComposedTree()) { It would be more stylish to use ComposedTreeAncestorIterator. The current composedTreeAncestors() starts from the parent though so dealing with the OrSelf part here would require refactoring a bit (or adding new composedTreeLineage() helper that starts from the current node). I think we should eventually get rid of all these random helpers. On the other hand just switching parentOrShadowHostNode->parentInComposedTree is a good way to make progress fast. Comment on attachment 290159 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=290159&action=review >> Source/WebCore/dom/Node.cpp:1845 >> + for (Node* node = this; node; node = node->parentInComposedTree()) { > > It would be more stylish to use ComposedTreeAncestorIterator. The current composedTreeAncestors() starts from the parent though so dealing with the OrSelf part here would require refactoring a bit (or adding new composedTreeLineage() helper that starts from the current node). > > I think we should eventually get rid of all these random helpers. On the other hand just switching parentOrShadowHostNode->parentInComposedTree is a good way to make progress fast. I'd keep parentInComposedTree for now, and we can do this in a separate patch if we'd so wished. Committed r206605: <http://trac.webkit.org/changeset/206605> |