| Summary: | Web Inspector: adopt Object.awaitEvent in LayoutTests/inspector/model | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 161634 | ||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2016-09-16 10:51:02 PDT
Created attachment 289135 [details]
Patch
Comment on attachment 289135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289135&action=review Please post a new version that reverts setTimeout changes for EWS. then I will r+ it. > LayoutTests/inspector/model/scope-chain-node.html:77 > + InspectorTest.evaluateInPage("testAllScopes()"); Please keep this as a setTimeout. Joe says it is necessary to do this whenever we rely on stack traces not including stack frames from InspectorTest code. > LayoutTests/inspector/model/scope-chain-node.html:97 > + InspectorTest.evaluateInPage("testFunctionNameScope1()"); See above. > LayoutTests/inspector/model/scope-chain-node.html:117 > + InspectorTest.evaluateInPage("testFunctionNameScope2()"); Ditto. > LayoutTests/inspector/model/scope-chain-node.html:167 > + InspectorTest.evaluateInPage("testBlockScopes()"); Ditto. Created attachment 289274 [details]
Patch
Comment on attachment 289274 [details]
Patch
r=me
Comment on attachment 289274 [details] Patch Clearing flags on attachment: 289274 Committed r206152: <http://trac.webkit.org/changeset/206152> All reviewed patches have been landed. Closing bug. |