Summary: | JavaScript regular expressions should match UTF-16 code units rather than characters | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | JavaScriptCore | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | eric | ||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Darin Adler
2007-11-30 07:02:13 PST
Created attachment 17606 [details]
patch, speeds up SunSpider
Comment on attachment 17606 [details]
patch, speeds up SunSpider
2425 d = *++ptr;
The precedence here seems correct, but potentially confusing. Maybe *(++ptr) would be better?
757 int c = *stack.currentFrame->args.subjectPtr++;
Again, parentheses might make it clearer what precedence you're expecting here (and in the other instances of this expression).
1640 if (stack.currentFrame->args.subjectPtr >= md.end_subject || isNewline(*stack.currentFrame->args.subjectPtr))
Why did you leave the comparison with md.end_subject here but now elsewhere?
r=me
Committed revision 28243. |