Bug 162039

Summary: [media-source] Only fire 'resize' events when new sized frame is displayed, not parsed.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161725    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews107 for mac-yosemite-wk2
none
Archive of layout-test-results from ews114 for mac-yosemite
none
Patch none

Jer Noble
Reported 2016-09-15 15:42:04 PDT
[media-source] Only fire 'resize' events when new sized frame is displayed, not parsed.
Attachments
Patch (13.44 KB, patch)
2016-09-15 15:57 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (854.00 KB, application/zip)
2016-09-15 16:49 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.24 MB, application/zip)
2016-09-15 16:53 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews114 for mac-yosemite (1.38 MB, application/zip)
2016-09-15 16:59 PDT, Build Bot 		no flags
Details
Patch (12.82 KB, patch)
2016-09-16 00:13 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-09-15 15:57:48 PDT
Created attachment 289011 [details] Patch
Jer Noble
Comment 2 2016-09-15 16:38:04 PDT
<rdar://problem/28179011>
Build Bot
Comment 3 2016-09-15 16:49:46 PDT
Comment on attachment 289011 [details] Patch Attachment 289011 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2082686 New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-framesize.html imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html
Build Bot
Comment 4 2016-09-15 16:49:49 PDT
Created attachment 289015 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2016-09-15 16:53:15 PDT
Comment on attachment 289011 [details] Patch Attachment 289011 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2082694 New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-framesize.html imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html
Build Bot
Comment 6 2016-09-15 16:53:17 PDT
Created attachment 289016 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-09-15 16:59:16 PDT
Comment on attachment 289011 [details] Patch Attachment 289011 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2082712 New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-framesize.html imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html
Build Bot
Comment 8 2016-09-15 16:59:19 PDT
Created attachment 289017 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Jer Noble
Comment 9 2016-09-16 00:13:28 PDT
Created attachment 289040 [details] Patch
Eric Carlson
Comment 10 2016-09-16 09:10:23 PDT
Comment on attachment 289040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289040&action=review > Source/WebCore/ChangeLog:23 > + (WebCore::SourceBuffer::reenqueueMediaForTime): When re-enqueing, enqueue the next decodable > + sample, even if it doesn't include the current time. This handles cases where the current > + time is 0, and the first video sample starts at 0.033. Nice!
WebKit Commit Bot
Comment 11 2016-09-16 09:24:07 PDT
Comment on attachment 289040 [details] Patch Clearing flags on attachment: 289040 Committed r206025: <http://trac.webkit.org/changeset/206025>
WebKit Commit Bot
Comment 12 2016-09-16 09:24:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.