Bug 162023

Summary: URLParser: Check for invalid characters in the host
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Alex Christensen
Reported 2016-09-15 11:03:00 PDT
URLParser: Check for invalid characters in the host
Attachments
Patch (2.76 KB, patch)
2016-09-15 11:04 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-09-15 11:04:33 PDT
Created attachment 288974 [details] Patch
Alex Christensen
Comment 2 2016-09-15 11:23:22 PDT
Comment on attachment 288974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288974&action=review > Source/WebCore/platform/URLParser.cpp:1579 > + if (isInvalidDomainCharacter(*iterator)) > + return false; > if (*iterator == ':') > break; The check for colon should come first. The first colon means we are starting to parse the port. This is covered by API tests.
Alex Christensen
Comment 3 2016-09-15 11:23:30 PDT
http://trac.webkit.org/changeset/205988
Note You need to log in before you can comment on or make changes to this bug.