Summary: | stringProtoFuncRepeatCharacter will return `null` when it should not | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, joepeck, keith_miller, mark.lam, msaboff, oliver, ticaiolima, ysuzuki | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Saam Barati
2016-09-13 19:49:37 PDT
The bug also goes away when @toLength is not inlined into padStart. Created attachment 290133 [details]
patch
Comment on attachment 290133 [details]
patch
r=me
Created attachment 290145 [details]
patch
take 2. I removed the caller that expected the null result value and instead made protoFuncRepeatCharacter throw OOM when it will construct too long of a string.
Comment on attachment 290145 [details]
patch
r=me
Comment on attachment 290145 [details] patch Clearing flags on attachment: 290145 Committed r206573: <http://trac.webkit.org/changeset/206573> All reviewed patches have been landed. Closing bug. |