Bug 161918

Summary: Remove CSS keyword properties from CSSParser::parseValue(CSSPropertyID, bool)
Product: WebKit Reporter: Daniel Bates <dbates>
Component: CSSAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, simon.fraser, zalan
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Daniel Bates
Reported 2016-09-13 11:35:22 PDT
There is little to no value in calling ASSERT_NOT_REACHED() from CSSParser::parseValue(CSSPropertyID, bool) when processing a CSS keyword property (properties that only accept keyword values) given that the switch block in CSSParser::parseValue(CSSPropertyID, bool) defaults to parsing a unrecognized CSS properties as SVG CSS properties. We should remove all CSS keyword property case statements from CSSParser::parseValue(CSSPropertyID, bool).
Attachments
Patch (6.52 KB, patch)
2016-09-13 11:57 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (6.54 KB, patch)
2016-09-13 11:59 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-09-13 11:57:10 PDT
Created attachment 288708 [details] Patch
Daniel Bates
Comment 2 2016-09-13 11:59:32 PDT
Created attachment 288709 [details] Patch Fix wording in ChangeLog.
Daniel Bates
Comment 3 2016-09-13 12:03:38 PDT
Comment on attachment 288709 [details] Patch Clearing flags on attachment: 288709 Committed r205868: <http://trac.webkit.org/changeset/205868>
Daniel Bates
Comment 4 2016-09-13 12:03:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.