Bug 161884

Summary:

[media-source] MediaSource.addSourceBuffer(null) should throw an exception

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eric.carlson, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

161881

Bug Blocks:

161725

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews112 for mac-yosemite	none
Patch	none

Jer Noble

Reported 2016-09-12 16:43:03 PDT

[media-source] MediaSource.addSourceBuffer(null) should throw an exception

Attachments
Patch (5.52 KB, patch) 2016-09-12 16:46 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.26 MB, application/zip) 2016-09-12 17:28 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-yosemite (873.82 KB, application/zip) 2016-09-12 17:46 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-yosemite (1.42 MB, application/zip) 2016-09-12 17:47 PDT, Build Bot	no flags	Details
Patch (5.52 KB, patch) 2016-09-13 12:35 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2016-09-12 16:46:14 PDT

Created attachment 288638 [details] Patch

Build Bot

Comment 2 2016-09-12 17:28:37 PDT

Comment on attachment 288638 [details] Patch Attachment 288638 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2062155 New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html

Build Bot

Comment 3 2016-09-12 17:28:40 PDT

Created attachment 288646 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-09-12 17:46:13 PDT

Comment on attachment 288638 [details] Patch Attachment 288638 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2062280 New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html

Build Bot

Comment 5 2016-09-12 17:46:16 PDT

Created attachment 288648 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-09-12 17:47:45 PDT

Comment on attachment 288638 [details] Patch Attachment 288638 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2062252 New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html

Build Bot

Comment 7 2016-09-12 17:47:48 PDT

Created attachment 288650 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5

Jer Noble

Comment 8 2016-09-13 08:40:04 PDT

The EWS failures are due to <https://bugs.webkit.org/show_bug.cgi?id=161881>, which will be fixed by that bug. Blocking this against that.

Jer Noble

Comment 9 2016-09-13 12:35:06 PDT

Created attachment 288715 [details] Patch

WebKit Commit Bot

Comment 10 2016-09-13 17:13:49 PDT

Comment on attachment 288715 [details] Patch Clearing flags on attachment: 288715 Committed r205890: <http://trac.webkit.org/changeset/205890>

WebKit Commit Bot

Comment 11 2016-09-13 17:13:53 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.