Bug 161874

Summary:

HTMLButtonElement.prototype.click should be HTMLElement.prototype.click

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kondapallykalyan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2016-09-12 15:05:06 PDT

Summary: HTMLButtonElement.prototype.click should be HTMLElement.prototype.click Seems we have "void click()" in HTMLButtonElement's IDL even though its already handled by HTMLElement. My guess is this was for ObjC bindings generation, but that is no longer necessary. However, this extra declaration causes an unexpected observable affect on the page. Eliminate it.

Attachments
[PATCH] Proposed Fix (3.01 KB, patch) 2016-09-12 15:07 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-09-12 15:07:32 PDT

Created attachment 288617 [details] [PATCH] Proposed Fix

Chris Dumez

Comment 2 2016-09-12 16:14:43 PDT

Comment on attachment 288617 [details] [PATCH] Proposed Fix r=me

WebKit Commit Bot

Comment 3 2016-09-12 16:36:04 PDT

Comment on attachment 288617 [details] [PATCH] Proposed Fix Clearing flags on attachment: 288617 Committed r205839: <http://trac.webkit.org/changeset/205839>

WebKit Commit Bot

Comment 4 2016-09-12 16:36:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.