Bug 161855

Summary: Add ref-counted ColorImpl to Color
Product: WebKit Reporter: Dean Jackson <dino>
Component: Layout and RenderingAssignee: Dean Jackson <dino>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160520    
Attachments:
Description Flags
Patch
none
Patch
none
Patch simon.fraser: review+

Dean Jackson
Reported 2016-09-11 20:52:44 PDT
As part of https://bugs.webkit.org/show_bug.cgi?id=160520 : Add a RefPtr to a ColorImpl from Color. This, by itself, is useless, so it won't land in isolation.
Attachments
Patch (13.59 KB, patch)
2016-09-11 20:56 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (14.77 KB, patch)
2016-09-11 21:46 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (16.35 KB, patch)
2016-09-12 15:55 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-09-11 20:53:10 PDT
<rdar://problem/28253890>
Dean Jackson
Comment 2 2016-09-11 20:56:47 PDT
Created attachment 288547 [details] Patch
Dean Jackson
Comment 3 2016-09-11 21:46:23 PDT
Created attachment 288549 [details] Patch
WebKit Commit Bot
Comment 4 2016-09-11 21:49:02 PDT
Attachment 288549 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:16: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dean Jackson
Comment 5 2016-09-12 15:55:03 PDT
Created attachment 288627 [details] Patch
Simon Fraser (smfr)
Comment 6 2016-09-12 17:06:15 PDT
Comment on attachment 288627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288627&action=review > Source/WebCore/platform/graphics/Color.h:196 > RGBA32 m_color; > bool m_valid; > + RefPtr<ColorImpl> m_colorImpl; Color is 16 bytes with this layout, but would be 13 bytes if you put the RefPtr first.
Dean Jackson
Comment 7 2016-09-12 17:59:32 PDT
Comment on attachment 288627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288627&action=review >> Source/WebCore/platform/graphics/Color.h:196 >> + RefPtr<ColorImpl> m_colorImpl; > > Color is 16 bytes with this layout, but would be 13 bytes if you put the RefPtr first. This doesn't matter since m_color and m_valid will go away, and Color will end up as 8 bytes. I'm splitting the patches into small chunks to make it reasonable. This part will only land when all the component pieces are ready, so that we won't ever be in a situation with a 16 byte Color.
Dean Jackson
Comment 8 2016-10-03 14:15:57 PDT
Now done a better way in https://bugs.webkit.org/show_bug.cgi?id=162878
Note You need to log in before you can comment on or make changes to this bug.